CXP-539 Fix how expired invitations are identified - #154

CXP-539

Connector PR Review: CXP-539 Fix how expired invitations are identified

Blocking Issues: 0 | Suggestions: 1 | Threads Resolved: 0
Review mode: full
View review run

Review Summary

This small change in pkg/connector/invitation.go switches the expired-invitation filter from an exact string equality check (!= "expired") to a case-insensitive substring match (strings.Contains). The GitHub API returns a full sentence (e.g. "Invitation expired. User did not accept this invite for 7 days") rather than the bare keyword, so the old check was silently skipping all expired invitations. The fix is correct and well-scoped.

Security Issues

None found.

Correctness Issues

None found.

Suggestions

• pkg/connector/invitation.go:194-195: The substring match on "expired" is pragmatic but could theoretically match a future failure reason that coincidentally contains that word. A strings.HasPrefix on strings.ToLower(failedReason) checking for "invitation expired" or a regex would be slightly more precise, though the current approach is reasonable given the known API responses.